Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jenkins: exclude testing on vs2019 on Node.js < 10 #2085

Merged
merged 1 commit into from
Dec 11, 2019
Merged

jenkins: exclude testing on vs2019 on Node.js < 10 #2085

merged 1 commit into from
Dec 11, 2019

Conversation

richardlau
Copy link
Member

@richardlau richardlau mentioned this pull request Dec 9, 2019
Closed
mhdawson
mhdawson approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau mentioned this pull request Dec 9, 2019
Closed
@mhdawson mhdawson mentioned this pull request Dec 9, 2019
Closed
joaocgreis
joaocgreis approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@joaocgreis joaocgreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to merging this to fix the job for the moment. I have changes queued up for this file as well, will discuss in the issue.

@richardlau richardlau merged commit 8fab072 into master Dec 11, 2019
@richardlau
Copy link
Member Author

Test node-test-node-addon-api-new build:
https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-new/1335/console

Node.js major version: 8
Node.js version: null
Skipping smartos17-64 for Node.js 8
Skipping smartos18-64 for Node.js 8
Skipping win-vs2019 for Node.js 8
Skipping centos7-ppcle for Node.js 8
Skipping win-vs2017 for Node.js 8
Skipping ubuntu1804-64 for Node.js 8
Running nodes

@richardlau richardlau deleted the richardlau/version-selector-vs2019 branch March 7, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@joaocgreis joaocgreis joaocgreis approved these changes

Assignees
No one assigned
Labels
platform:windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardlau @joaocgreis @mhdawson